All packets that serialize with the serializeCountPacket function need mutex protection

the XOR/other packets get constantly created/deleted, if we call the function twice (we are multithreaded) it will cause a crash. We need to prevent with a unique_lock.

Client::SendRecipeList

PlayerItemList::serialize

EquipmentItemList::serialize

Player::GetSpellBookUpdatePacket <-- this is what we crashed on in the previous instance, but any are possible

PlayerSkillList::GetSkillPacket

char sheet is also involved, pretty much anywhere we have XOR packets or temp buffers that get deleted/newed for packets.

EquipmentItemList::serialize - updated to properly protect with MEquipmentItems PlayerItemList::serialize - already protected by MPlayerItems Player::GetSpellBookUpdatePacket - added a mutex to lock this function Client::SendRecipeList - uses nullptr for the orig/xor packet not impacted PlayerSkillList::GetSkillPacket - changed MPlayerSkills from shared to unique lock

image hat dieses Issue vor 2 Monaten aus einem Commit referenziert

Fix #565 - avoid crash, packet buffer overruns/overflows, Fix #563 cavoid crash all getcurrentspell on dead lua state after reload spells called

image hat vor 2 Monaten geschlossen

Anmelden, um an der Diskussion teilzunehmen.

#565 All packets that serialize with the serializeCountPacket function need mutex protection