#565 All packets that serialize with the serializeCountPacket function need mutex protection

Đã đóng
%! (template.HTML=4 tháng trước cách đây)đang mở bởi image · 3 ý kiến

the XOR/other packets get constantly created/deleted, if we call the function twice (we are multithreaded) it will cause a crash. We need to prevent with a unique_lock.

the XOR/other packets get constantly created/deleted, if we call the function twice (we are multithreaded) it will cause a crash. We need to prevent with a unique_lock.
image đã nhận xét 4 tháng trước cách đây
Người hợp tác

Client::SendRecipeList

PlayerItemList::serialize

EquipmentItemList::serialize

Player::GetSpellBookUpdatePacket <-- this is what we crashed on in the previous instance, but any are possible

PlayerSkillList::GetSkillPacket

Client::SendRecipeList PlayerItemList::serialize EquipmentItemList::serialize Player::GetSpellBookUpdatePacket <-- this is what we crashed on in the previous instance, but any are possible PlayerSkillList::GetSkillPacket
image đã nhận xét 4 tháng trước cách đây
Người hợp tác

char sheet is also involved, pretty much anywhere we have XOR packets or temp buffers that get deleted/newed for packets.

char sheet is also involved, pretty much anywhere we have XOR packets or temp buffers that get deleted/newed for packets.
image đã nhận xét 2 tháng trước cách đây
Người hợp tác

EquipmentItemList::serialize - updated to properly protect with MEquipmentItems PlayerItemList::serialize - already protected by MPlayerItems Player::GetSpellBookUpdatePacket - added a mutex to lock this function Client::SendRecipeList - uses nullptr for the orig/xor packet not impacted PlayerSkillList::GetSkillPacket - changed MPlayerSkills from shared to unique lock

EquipmentItemList::serialize - updated to properly protect with MEquipmentItems PlayerItemList::serialize - already protected by MPlayerItems Player::GetSpellBookUpdatePacket - added a mutex to lock this function Client::SendRecipeList - uses nullptr for the orig/xor packet not impacted PlayerSkillList::GetSkillPacket - changed MPlayerSkills from shared to unique lock
Đăng nhập để tham gia bình luận.
Đang tải...
Hủy bỏ
Lưu
Ở đây vẫn chưa có nội dung nào.