#291 Selling items for status

Closed
opened 3 years ago by neatz09 · 11 comments
neatz09 commented 3 years ago
  • need to implement a restriction of selling status/collectable items to specific merchants.
  • need to implement guild xp with a level check from status items and collectables to reward xp+guild status
  • merchants that can buy items for status will have no-buyback on the item(maybe add a status flag to the db) where as regular merchants will be able to be sold to for coin + allow buyback
- need to implement a restriction of selling status/collectable items to specific merchants. - need to implement guild xp with a level check from status items and collectables to reward xp+guild status - merchants that can buy items for status will have no-buyback on the item(maybe add a status flag to the db) where as regular merchants will be able to be sold to for coin + allow buyback
neatz09 commented 3 years ago
Collaborator

if guild is below level of the item the sell price will be coin + status in yellow, if at level or above it will be coin + status in blue

if guild is below level of the item the sell price will be coin + status in yellow, if at level or above it will be coin + status in blue
neatz09 commented 3 years ago
Collaborator

currently selling status items even with a value set does now display a value nor does it reward status

this apparently is because we have a guilded check for status -> requesting a rule to enable/disable this feature

currently selling status items even with a value set does now display a value nor does it reward status this apparently is because we have a guilded check for status -> requesting a rule to enable/disable this feature
image commented 3 years ago
Collaborator

Do we know if the sell item message includes the status amount?

this is what we have:

        if (quantity > 1)
            Message(CHANNEL_MERCHANT_BUY_SELL, "You sell %i %s to %s for %s.", quantity, master_item->CreateItemLink(GetVersion()).c_str(), spawn->GetName(), GetCoinMessage(total_sell_price).c_str());
        else
            Message(CHANNEL_MERCHANT_BUY_SELL, "You sell %s to %s for %s.", master_item->CreateItemLink(GetVersion()).c_str(), spawn->GetName(), GetCoinMessage(total_sell_price).c_str());

Looks like we already have merchant types for buyback and no buy back:

#define MERCHANT_TYPE_NO_BUY				1
#define MERCHANT_TYPE_NO_BUY_BACK			2
#define MERCHANT_TYPE_SPELLS				4
#define MERCHANT_TYPE_CRAFTING				8
#define MERCHANT_TYPE_REPAIR				16
#define MERCHANT_TYPE_LOTTO					32

merchant_type in the spawn table

Do we know if the sell item message includes the status amount? this is what we have: if (quantity > 1) Message(CHANNEL_MERCHANT_BUY_SELL, "You sell %i %s to %s for %s.", quantity, master_item->CreateItemLink(GetVersion()).c_str(), spawn->GetName(), GetCoinMessage(total_sell_price).c_str()); else Message(CHANNEL_MERCHANT_BUY_SELL, "You sell %s to %s for %s.", master_item->CreateItemLink(GetVersion()).c_str(), spawn->GetName(), GetCoinMessage(total_sell_price).c_str()); Looks like we already have merchant types for buyback and no buy back: ``` #define MERCHANT_TYPE_NO_BUY 1 #define MERCHANT_TYPE_NO_BUY_BACK 2 #define MERCHANT_TYPE_SPELLS 4 #define MERCHANT_TYPE_CRAFTING 8 #define MERCHANT_TYPE_REPAIR 16 #define MERCHANT_TYPE_LOTTO 32 ``` merchant_type in the spawn table
image commented 3 years ago
Collaborator
  • Removed the 'guild' requirement for personal status points (do we even need a rule? Was that a thing?). They can be guilded and get a /10 status for their guild + guild xp when selling, if in guild of course.
  • Fixed the quantity being incorrectly calculated for status buy
- Removed the 'guild' requirement for personal status points (do we even need a rule? Was that a thing?). They can be guilded and get a /10 status for their guild + guild xp when selling, if in guild of course. - Fixed the quantity being incorrectly calculated for status buy
neatz09 commented 3 years ago
Collaborator

It does pop up a message when you sell for status.. Ill get check what the actual message is.. as for no buyback... If I recall I believe that sets everything you sell to that merchant to no buy back not just singular items

It does pop up a message when you sell for status.. Ill get check what the actual message is.. as for no buyback... If I recall I believe that sets everything you sell to that merchant to no buy back not just singular items
image commented 3 years ago
Collaborator

for the merchant types no buy back means we don't display the 'buy back' panel. For the 'no buy' means we don't show the sell panel.

for the merchant types no buy back means we don't display the 'buy back' panel. For the 'no buy' means we don't show the sell panel.
neatz09 commented 3 years ago
Collaborator

Screenshots! also no-buyback will not work in this case :(

Screenshots! also no-buyback will not work in this case :(
ememjr commented 3 years ago
Collaborator

unless all items with no buy back fall into certain item types then we will probably need to have a no_buy_back flag. Merchents have the option to not have the nobuyback tab, as we know, and items that to dont allow buyback will not show up in the tab some things that do not allow buyback

  1. anything sold for status
unless all items with no buy back fall into certain item types then we will probably need to have a no_buy_back flag. Merchents have the option to not have the nobuyback tab, as we know, and items that to dont allow buyback will not show up in the tab some things that do not allow buyback 1. anything sold for status
image commented 3 years ago
Collaborator

heres the no_buy_back flag

alter table items add column no_buy_back tinyint(1) unsigned not null default 0;

added a new merchant type: #define MERCHANT_TYPE_CITYMERCHANT 64

this will be the merchant type that allows selling for status, but omits status items from buyback.

Any other merchants will allow selling, but status is omitted.

![https://cdn.discordapp.com/attachments/603677936582918189/817033009743265792/unknown.png](https://cdn.discordapp.com/attachments/603677936582918189/817033009743265792/unknown.png) ![https://cdn.discordapp.com/attachments/603677936582918189/817033330733219881/unknown.png](https://cdn.discordapp.com/attachments/603677936582918189/817033330733219881/unknown.png) heres the no_buy_back flag ``` alter table items add column no_buy_back tinyint(1) unsigned not null default 0; ``` added a new merchant type: #define MERCHANT_TYPE_CITYMERCHANT 64 this will be the merchant type that allows selling for status, but omits status items from buyback. Any other merchants will allow selling, but status is omitted.
image commented 3 years ago
Collaborator

only outstanding part on this is

  • need to implement guild xp with a level check from status items and collectables to reward xp+guild status

how do we know what level check? Is this depending on the status amount?

only outstanding part on this is - need to implement guild xp with a level check from status items and collectables to reward xp+guild status how do we know what level check? Is this depending on the status amount?
neatz09 commented 3 years ago
Collaborator

well im not sure if this is an item flag or just a text entry we never collected... but possibly look into this OR we could add a say a "Status_Level" field and i can fill it it(eventually)

well im not sure if this is an item flag or just a text entry we never collected... but possibly look into this OR we could add a say a "Status_Level" field and i can fill it it(eventually)
image referenced this issue from a commit 3 years ago
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.